Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NavLink class to use constructor property promotion and add immutable methods. #209

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Refactor NavLink class to use constructor property promotion and add immutable methods. #209

merged 4 commits into from
Jan 21, 2025

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌

@terabytesoftw terabytesoftw requested a review from a team January 21, 2025 12:57
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Jan 21, 2025
samdark
samdark approved these changes Jan 21, 2025
View reviewed changes
src/NavLink.php Outdated Show resolved Hide resolved
src/NavLink.php Outdated Show resolved Hide resolved
src/NavLink.php Outdated Show resolved Hide resolved
src/NavLink.php Outdated Show resolved Hide resolved
src/NavLink.php Outdated Show resolved Hide resolved
src/NavLink.php Outdated Show resolved Hide resolved
@terabytesoftw terabytesoftw merged commit 49d8523 into master Jan 21, 2025
6 of 16 checks passed
@terabytesoftw terabytesoftw deleted the add-nav-methods-immutables branch January 21, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terabytesoftw @samdark